Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compressed WebSocketWriter benchmark #9799

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 11, 2024

To validate if #9795 is a good change or not

@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.10 backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Nov 11, 2024
@bdraco bdraco requested a review from asvetlov as a code owner November 11, 2024 14:06
Copy link

codspeed-hq bot commented Nov 11, 2024

CodSpeed Performance Report

Merging #9799 will not alter performance

Comparing compressed_websocket_benchmark (b380def) with master (b947e47)

Summary

✅ 16 untouched benchmarks

🆕 1 new benchmarks

Benchmarks breakdown

Benchmark master compressed_websocket_benchmark Change
🆕 test_send_one_hundred_websocket_compressed_messages[pyloop] N/A 3.3 ms N/A

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (b947e47) to head (b380def).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9799   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files         118      118           
  Lines       35998    36007    +9     
  Branches     4279     4281    +2     
=======================================
+ Hits        35527    35536    +9     
  Misses        316      316           
  Partials      155      155           
Flag Coverage Δ
CI-GHA 98.58% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.26% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.04% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.34% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.18% <100.00%> (-0.01%) ⬇️
Py-3.10.15 97.74% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 97.78% <100.00%> (-0.01%) ⬇️
Py-3.11.9 97.24% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 98.33% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 98.32% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.11% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.66% <100.00%> (-0.05%) ⬇️
Py-pypy7.3.16 97.27% <100.00%> (+<0.01%) ⬆️
VM-macos 97.34% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 98.26% <100.00%> (+<0.01%) ⬆️
VM-windows 96.04% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) November 11, 2024 14:12
@bdraco bdraco merged commit d40b183 into master Nov 11, 2024
41 of 42 checks passed
@bdraco bdraco deleted the compressed_websocket_benchmark branch November 11, 2024 14:18
Copy link
Contributor

patchback bot commented Nov 11, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/d40b1839dbd794db89b82dd36530cd40718b8b07/pr-9799

Backported as #9801

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Nov 11, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/d40b1839dbd794db89b82dd36530cd40718b8b07/pr-9799

Backported as #9802

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 11, 2024
bdraco added a commit that referenced this pull request Nov 11, 2024
bdraco added a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant