Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v3.8.2 #6919

Merged
merged 5 commits into from
Sep 21, 2022
Merged

Release v3.8.2 #6919

merged 5 commits into from
Sep 21, 2022

Conversation

webknjaz
Copy link
Member

What do these changes do?

This is a release preparation for v3.8.2.

Are there changes in behavior for the user?

The sdist will be buildable under Python 3.11. Wheels for Python 3.11 built with rc2 are going to be available.

Related issue number

N/A

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #6919 (9fdf548) into 3.8 (9fdf548) will not change coverage.
The diff coverage is n/a.

❗ Current head 9fdf548 differs from pull request most recent head 99c8d0d. Consider uploading reports for the commit 99c8d0d to get more accurate results

@@           Coverage Diff           @@
##              3.8    #6919   +/-   ##
=======================================
  Coverage   97.39%   97.39%           
=======================================
  Files         107      107           
  Lines       30970    30970           
  Branches     3922     3922           
=======================================
  Hits        30162    30162           
  Misses        604      604           
  Partials      204      204           
Flag Coverage Δ
CI-GHA 97.25% <0.00%> (ø)
OS-Linux 96.90% <0.00%> (ø)
OS-Windows 95.23% <0.00%> (ø)
OS-macOS 96.64% <0.00%> (ø)
Py-3.10.6 96.30% <0.00%> (ø)
Py-3.10.7 96.66% <0.00%> (ø)
Py-3.11.0-rc.2 96.21% <0.00%> (ø)
Py-3.6.15 96.37% <0.00%> (ø)
Py-3.6.8 94.75% <0.00%> (ø)
Py-3.7.13 96.41% <0.00%> (ø)
Py-3.7.14 96.41% <0.00%> (ø)
Py-3.7.9 94.89% <0.00%> (ø)
Py-3.8.10 94.81% <0.00%> (ø)
Py-3.8.13 96.49% <0.00%> (ø)
Py-3.9.13 96.77% <0.00%> (ø)
Py-3.9.14 96.23% <0.00%> (ø)
Py-pypy7.3.9 96.07% <0.00%> (ø)
VM-macos 96.64% <0.00%> (ø)
VM-ubuntu 96.90% <0.00%> (ø)
VM-windows 95.23% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@webknjaz webknjaz marked this pull request as ready for review September 20, 2022 10:03
@webknjaz webknjaz requested a review from asvetlov as a code owner September 20, 2022 10:03
@Dreamsorcerer
Copy link
Member

Appears to be an open backport #6540. Though it may only be updating a test.

I'd also like to see #6889 included, if there's no objections to that.

@webknjaz
Copy link
Member Author

webknjaz commented Sep 20, 2022

@Dreamsorcerer may I get an approval for this changelog? One item that I'm not sure about is py3.5. Technically, it's not an API change and pip handles it very well these days. So it's probably fine that it's backported into a patch release. Plus the default wheel building setup doesn't produce those wheels anymore anyway.
I wanted to make the last release of the 3.8.x stream with minimal changes and forget about this branch. WDYT?

Potential release workflow is at https://github.com/aio-libs/aiohttp/actions/runs/3089216983. It'll need to be approved too.

@Dreamsorcerer
Copy link
Member

Dreamsorcerer commented Sep 20, 2022

One item that I'm not sure about is py3.5.

Seems fine to me, 3.5 is long dead, and 3.6 is already unsupported (and removed from the aiohttp 3.9 release).

I wanted to make the last release of the 3.8.x stream with minimal changes and forget about this branch. WDYT?

Seems fine, but possible we might need it for an emergency fix or similar until 3.9 is ready for release.

@webknjaz
Copy link
Member Author

Appears to be an open backport #6540. Though it may only be updating a test.

Looks like I've fixed that test already, the rest are formatting changes. Plus there's conflicts.

@webknjaz
Copy link
Member Author

I'd also like to see #6889 included, if there's no objections to that.

That seems straightforward, will do.

@webknjaz
Copy link
Member Author

I double-checked stuff from https://github.com/aio-libs/aiohttp/issues?q=is%3Aopen+label%3Abackport-3.8+sort%3Aupdated-desc and it doesn't seem like there's anything else that could be included. Plus, they all need a newer backport label now.

@webknjaz
Copy link
Member Author

I'd also like to see #6889 included, if there's no objections to that.

Backported.

@webknjaz
Copy link
Member Author

webknjaz commented Sep 20, 2022

New release attempt: https://github.com/aio-libs/aiohttp/actions/runs/3090829504. Will have to wait for the CI resources to free up, then an approval will be needed before publishing.

@webknjaz
Copy link
Member Author

webknjaz commented Sep 20, 2022

New release attempt: aio-libs/aiohttp/actions/runs/3090829504. Will have to wait for the CI resources to free up, then an approval will be needed before publishing.

New attempt: https://github.com/aio-libs/aiohttp/actions/runs/3091013580

@webknjaz webknjaz self-assigned this Sep 20, 2022
@webknjaz
Copy link
Member Author

Seems like GHA hits GH's rate limits and jobs fail on fetching the Git repo. It'll need some restarts to succeed.

@webknjaz webknjaz force-pushed the release/v3.8.2 branch 3 times, most recently from 1c17645 to 58f7f0e Compare September 20, 2022 18:41
@webknjaz
Copy link
Member Author

webknjaz commented Sep 20, 2022

@webknjaz webknjaz temporarily deployed to release September 20, 2022 21:32 Inactive
@webknjaz
Copy link
Member Author

@webknjaz
Copy link
Member Author

ValueError: Version check mismatch: 3.8.1 != 3.8.2

🤦‍♂️

@webknjaz webknjaz force-pushed the release/v3.8.2 branch 4 times, most recently from b2a4cbf to 51eb60a Compare September 20, 2022 22:23
@webknjaz
Copy link
Member Author

@webknjaz webknjaz temporarily deployed to release September 21, 2022 00:17 Inactive
@webknjaz webknjaz merged commit 99c8d0d into aio-libs:3.8 Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants