Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6313/d149eff6 backport][3.9] docs: Fix statement about setUpAsync() and tearDownAsync() #6318

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Nov 16, 2021

This is a backport of PR #6313 as merged into master (d149eff).

Since #4732, it's wrong to says that
setUpAsync() and tearDownAsync() do nothing and can be overridden without
calling super.setUpAsync() and super.tearDownAsync().

What do these changes do?

Fix documentation

Are there changes in behavior for the user?

No

Related issue number

None

Checklist

Only docs.


Remark:
My rst preview wasn't working, I hope there is no rst mistakes.

Since #4732, it's wrong to says that
`setUpAsync()` and `tearDownAsync()` do nothing and can be overridden without
calling `super.setUpAsync()` and `super.tearDownAsync()`.

(cherry picked from commit d149eff)
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

❗ No coverage uploaded for pull request base (3.9@dfe3a52). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head d149eff differs from pull request most recent head bcdae45. Consider uploading reports for the commit bcdae45 to get more accurate results
Impacted file tree graph

@@          Coverage Diff           @@
##             3.9    #6318   +/-   ##
======================================
  Coverage       ?   93.31%           
======================================
  Files          ?      103           
  Lines          ?    30369           
  Branches       ?     2731           
======================================
  Hits           ?    28340           
  Misses         ?     1852           
  Partials       ?      177           
Flag Coverage Δ
unit 93.24% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfe3a52...bcdae45. Read the comment docs.

@asvetlov asvetlov merged commit c693b74 into 3.9 Nov 16, 2021
@asvetlov asvetlov deleted the patchback/backports/3.9/d149eff62e1e110d2eafac8a79219dd2e56b8581/pr-6313 branch November 16, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants