Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better typing #5078

Merged
merged 2 commits into from
Oct 18, 2020
Merged

Better typing #5078

merged 2 commits into from
Oct 18, 2020

Conversation

asvetlov
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 18, 2020

Codecov Report

Merging #5078 into master will decrease coverage by 0.01%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5078      +/-   ##
==========================================
- Coverage   97.65%   97.63%   -0.02%     
==========================================
  Files          43       43              
  Lines        8983     8999      +16     
  Branches     1412     1413       +1     
==========================================
+ Hits         8772     8786      +14     
- Misses         98       99       +1     
- Partials      113      114       +1     
Flag Coverage Δ
#unit 97.63% <94.44%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web_app.py 97.30% <ø> (ø)
aiohttp/web_response.py 97.78% <ø> (ø)
aiohttp/web_runner.py 97.77% <ø> (ø)
aiohttp/web_urldispatcher.py 98.24% <93.54%> (-0.26%) ⬇️
aiohttp/client_proto.py 96.66% <100.00%> (ø)
aiohttp/client_reqrep.py 97.36% <100.00%> (ø)
aiohttp/tracing.py 100.00% <100.00%> (ø)
aiohttp/web_routedef.py 100.00% <100.00%> (ø)
aiohttp/worker.py 97.45% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ee92db...40a6483. Read the comment docs.

@asvetlov asvetlov merged commit 6db8b67 into master Oct 18, 2020
@asvetlov asvetlov deleted the better-typing branch October 18, 2020 20:25
aio-libs-github-bot bot pushed a commit that referenced this pull request Oct 18, 2020
@aio-libs-github-bot
Copy link
Contributor

💚 Backport successful

The PR was backported to the following branches:

aio-libs-github-bot bot added a commit that referenced this pull request Oct 18, 2020
Backports the following commits to 3.7:
 - Better typing (#5078)

Co-authored-by: Andrew Svetlov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants