Skip to content

routing subsystem refactoring #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fafhrd91 wants to merge 4 commits into from
Closed

routing subsystem refactoring #435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa3a7ab
routing subsystem refactoring
fafhrd91 Jul 9, 2015
2fea648
fix typo
fafhrd91 Jul 9, 2015
4d530f6
fix typo
fafhrd91 Jul 9, 2015
28d2048
move handler checks to View ctor
fafhrd91 Jul 9, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions aiohttp/hdrs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
METH_POST = upstr('POST')
METH_PUT = upstr('PUT')
METH_TRACE = upstr('TRACE')
METH_PURGE = upstr('PURGE')
Copy link
Member

@kxepal kxepal Jul 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like unrelated change. PURGE is used for Varnish needs, but what's it purpose for aiohttp?


ACCEPT = upstr('ACCEPT')
ACCEPT_CHARSET = upstr('ACCEPT-CHARSET')
Expand Down
6 changes: 5 additions & 1 deletion aiohttp/web.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,11 @@ def handle_request(self, message, payload):
"got {!r} [middlewares {!r}]").format(
match_info.handler, type(resp), self._middlewares)
except HTTPException as exc:
resp = exc
route = self._router.get_system_route(exc.status_code)
try:
resp = yield from route.handler(request, exc)
except:
resp = exc

resp_msg = resp.start(request)
yield from resp.write_eof()
Expand Down
Loading