Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't start heartbeat until _writer is set (#4062) #4323

Merged
merged 1 commit into from
Nov 9, 2019
Merged

Don't start heartbeat until _writer is set (#4062) #4323

merged 1 commit into from
Nov 9, 2019

Conversation

erik-megarad
Copy link
Contributor

What do these changes do?

As seen in #4062 . self._reset_heartbeat() is being called during _pre_start, which is before the writer is set. The error in the issue will occur if the writer isn't set before the first heartbeat is sent.

This change waits until the writer is set, during _post_start, to start sending heartbeats.

Are there changes in behavior for the user?

None

Related issue number

#4062

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 5, 2019
@asvetlov asvetlov merged commit 705c6c6 into aio-libs:master Nov 9, 2019
@asvetlov
Copy link
Member

asvetlov commented Nov 9, 2019

Thanks!

asvetlov pushed a commit that referenced this pull request Nov 9, 2019
(cherry picked from commit 705c6c6)

Co-authored-by: Erik Peterson <[email protected]>
asvetlov added a commit that referenced this pull request Nov 9, 2019
frederikaalund pushed a commit to sbtinstruments/aiohttp that referenced this pull request Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants