-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid calling len on the same data in the stream reader twice #10088
Conversation
CodSpeed Performance ReportMerging #10088 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #10088 +/- ##
=======================================
Coverage 98.76% 98.76%
=======================================
Files 121 121
Lines 36866 36867 +1
Branches 4396 4396
=======================================
+ Hits 36409 36410 +1
Misses 311 311
Partials 146 146
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #10090 🤖 @patchback |
(cherry picked from commit 29c3ca9)
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #10091 🤖 @patchback |
(cherry picked from commit 29c3ca9)
…a in the stream reader twice (#10090) Co-authored-by: J. Nick Koston <[email protected]>
…a in the stream reader twice (#10091) Co-authored-by: J. Nick Koston <[email protected]>
This is trivial but it is noticeable in the profile.
before
after