Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export PrefixedSubAppResource in aiohttp.web #6889

Merged
merged 4 commits into from
Sep 20, 2022
Merged

Conversation

Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented Aug 22, 2022

To match the documentation: https://docs.aiohttp.org/en/stable/web_reference.html#aiohttp.web.PrefixedSubAppResource

It's missing since this PR got merged: #3469.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 22, 2022
@Dreamsorcerer Dreamsorcerer mentioned this pull request Sep 20, 2022
5 tasks
@webknjaz webknjaz changed the title Export PrefixedSubAppResource in aiohttp.web Export PrefixedSubAppResource in aiohttp.web Sep 20, 2022
CHANGES/6889.bugfix Outdated Show resolved Hide resolved
CHANGES/6889.bugfix Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #6889 (8ed0061) into master (5bf9b4a) will increase coverage by 3.99%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6889      +/-   ##
==========================================
+ Coverage   93.40%   97.40%   +3.99%     
==========================================
  Files         104      106       +2     
  Lines       30647    30962     +315     
  Branches     3752     3179     -573     
==========================================
+ Hits        28625    30157    +1532     
+ Misses       1848      604    -1244     
- Partials      174      201      +27     
Flag Coverage Δ
CI-GHA 97.31% <ø> (?)
OS-Linux 96.97% <ø> (?)
OS-Windows 95.32% <ø> (?)
OS-macOS 96.60% <ø> (?)
Py-3.10.6 96.60% <ø> (?)
Py-3.10.7 96.96% <ø> (?)
Py-3.7.13 96.81% <ø> (?)
Py-3.8.13 96.75% <ø> (?)
Py-3.9.13 97.03% <ø> (?)
Py-3.9.14 96.48% <ø> (?)
VM-macos 96.60% <ø> (?)
VM-ubuntu 96.97% <ø> (?)
VM-windows 95.32% <ø> (?)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web.py 97.52% <ø> (-1.66%) ⬇️
tests/test_circular_imports.py 93.54% <0.00%> (-6.46%) ⬇️
tests/test_client_session.py 99.56% <0.00%> (-0.01%) ⬇️
tests/test_web_app.py 99.47% <0.00%> (ø)
tests/test_multipart.py 100.00% <0.00%> (ø)
tests/autobahn/client/client.py 96.42% <0.00%> (ø)
tests/autobahn/server/server.py 86.48% <0.00%> (ø)
tests/test_client_request.py 99.57% <0.00%> (+<0.01%) ⬆️
tests/test_web_functional.py 98.08% <0.00%> (+0.04%) ⬆️
... and 27 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@webknjaz webknjaz merged commit a648677 into master Sep 20, 2022
@webknjaz webknjaz deleted the Dreamsorcerer-patch-6 branch September 20, 2022 13:36
@patchback
Copy link
Contributor

patchback bot commented Sep 20, 2022

Backport to 3.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.8/a6486774bc7f799de2b5fd51d7fc0db4e4e0c3b9/pr-6889

Backported as #6921

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 20, 2022
To match the documentation:
https://docs.aiohttp.org/en/stable/web_reference.html#aiohttp.web.PrefixedSubAppResource

It's missing since this PR got merged:
#3469.

Co-authored-by: Sviatoslav Sydorenko <[email protected]>
(cherry picked from commit a648677)
@patchback
Copy link
Contributor

patchback bot commented Sep 20, 2022

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/a6486774bc7f799de2b5fd51d7fc0db4e4e0c3b9/pr-6889

Backported as #6922

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 20, 2022
To match the documentation:
https://docs.aiohttp.org/en/stable/web_reference.html#aiohttp.web.PrefixedSubAppResource

It's missing since this PR got merged:
#3469.

Co-authored-by: Sviatoslav Sydorenko <[email protected]>
(cherry picked from commit a648677)
webknjaz pushed a commit that referenced this pull request Sep 20, 2022
…`aiohttp.web` (#6921)

**This is a backport of PR #6889 as merged into master
(a648677).**

To match the documentation:
https://docs.aiohttp.org/en/stable/web_reference.html#aiohttp.web.PrefixedSubAppResource

It's missing since this PR got merged:
#3469.

Co-authored-by: Sam Bull <[email protected]>
webknjaz pushed a commit that referenced this pull request Sep 20, 2022
…`aiohttp.web` (#6922)

**This is a backport of PR #6889 as merged into master
(a648677).**

To match the documentation:
https://docs.aiohttp.org/en/stable/web_reference.html#aiohttp.web.PrefixedSubAppResource

It's missing since this PR got merged:
#3469.

Co-authored-by: Sam Bull <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants