Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default access log format tries to include Referer header but spells it correctly and thus it doesn't work #2633

Closed
EdRowe opened this issue Dec 29, 2017 · 2 comments

Comments

@EdRowe
Copy link

EdRowe commented Dec 29, 2017

The default access log format attempts to output the Referer HTTP request header, referring to it as "Referrer". The latter is the correct spelling of the word, but the inventors of the header misspelled it as "Referer". To make this work as intended, the LOG_FORMAT and the logging docs (which show the default log format) should be updated to use the misspelled version of the word.

LOG_FORMAT = '%a %t "%r" %s %b "%{Referrer}i" "%{User-Agent}i"'
vs
LOG_FORMAT = '%a %t "%r" %s %b "%{Referer}i" "%{User-Agent}i"'

The docs for the default log format also do not match the actual default log format in that it shows %l and %u which don't actually exist and %t which doesn't appear to be in the default log format.

@asvetlov
Copy link
Member

Thanks for report.

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants