[3.7] TCPConnector ttl_dns_cache type hint. (#4279). (#4280)

(cherry picked from commit 18b9274) Co-authored-by: Fernanda Guimarães <[email protected]>
aio-libs · Oct 26, 2019 · e246e1c · e246e1c
1 parent 15dc6aa
commit e246e1c
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/CHANGES/4270.doc b/CHANGES/4270.doc
@@ -0,0 +1 @@
+Changes doc and ttl_dns_cache type from int to Optional[int].
diff --git a/CONTRIBUTORS.txt b/CONTRIBUTORS.txt
@@ -94,6 +94,8 @@ Eugene Naydenov
 Eugene Nikolaiev
 Eugene Tolmachev
 Evert Lammerts
+Felix Yan
+Fernanda Guimarães
 FichteFoll
 Florian Scheffler
 Frederik Gladhorn

diff --git a/aiohttp/connector.py b/aiohttp/connector.py
@@ -713,7 +713,7 @@ class TCPConnector(BaseConnector):
 
     def __init__(self, *, verify_ssl: bool=True,
                  fingerprint: Optional[bytes]=None,
-                 use_dns_cache: bool=True, ttl_dns_cache: int=10,
+                 use_dns_cache: bool=True, ttl_dns_cache: Optional[int]=10,
                  family: int=0,
                  ssl_context: Optional[SSLContext]=None,
                  ssl: Union[None, bool, Fingerprint, SSLContext]=None,

diff --git a/docs/client_reference.rst b/docs/client_reference.rst
@@ -1038,7 +1038,7 @@ TCPConnector
       *side effects* also.
 
    :param int ttl_dns_cache: expire after some seconds the DNS entries, ``None``
-      means cached forever. By default 10 seconds.
+      means cached forever. By default 10 seconds (optional).
 
       In some environments the IP addresses related to a specific HOST can
       change after a specific time. Use this option to keep the DNS cache
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Changes doc and ttl_dns_cache type from int to Optional[int].