Apply SO_REUSEADDR to test server's socket (#4393)

aio-libs · Oct 16, 2020 · 859cb76 · 859cb76
1 parent acda154
commit 859cb76
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/CHANGES/4393.feature b/CHANGES/4393.feature
@@ -0,0 +1 @@
+Apply SO_REUSEADDR to test server's socket.
diff --git a/aiohttp/test_utils.py b/aiohttp/test_utils.py
@@ -5,6 +5,7 @@
 import functools
 import gc
 import inspect
+import os
 import socket
 import sys
 import unittest
@@ -57,12 +58,20 @@
     SSLContext = None
 
 
+REUSE_ADDRESS = os.name == 'posix' and sys.platform != 'cygwin'
+
+
 def get_unused_port_socket(host: str) -> socket.socket:
     return get_port_socket(host, 0)
 
 
 def get_port_socket(host: str, port: int) -> socket.socket:
     s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
+    if REUSE_ADDRESS:
+        # Windows has different semantics for SO_REUSEADDR,
+        # so don't set it. Ref:
+        # https://docs.microsoft.com/en-us/windows/win32/winsock/using-so-reuseaddr-and-so-exclusiveaddruse
+        s.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
     s.bind((host, port))
     return s