-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for getaddrinfo #118
Conversation
9efd0dd
to
5208bbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
The CI is not happy 😅 |
Sorry about that. Should be ok now |
Looks like macos can return more than one address so I adjusted the test as well. I created a fork, enabled actions, and verified a clean run bdraco#1 |
Cheers! |
I'll cut a release tonight. |
Thanks |
AsyncResolver was disabled by default because it did not implement all of functionality of ThreadedResolver because aiodns did not support getaddrinfo until aio-libs/aiodns#118 see #559
AsyncResolver was disabled by default because it did not implement all of functionality of ThreadedResolver because aiodns did not support getaddrinfo until aio-libs/aiodns#118 see aio-libs#559
AsyncResolver was disabled by default because it did not implement all of functionality of ThreadedResolver because aiodns did not support getaddrinfo until aio-libs/aiodns#118 see #559
AsyncResolver was disabled by default because it did not implement all of functionality of ThreadedResolver because aiodns did not support getaddrinfo until aio-libs/aiodns#118 see aio-libs#559
AsyncResolver was disabled by default because it did not implement all of functionality of ThreadedResolver because aiodns did not support getaddrinfo until aio-libs/aiodns#118 see #559
AsyncResolver was disabled by default because it did not implement all of functionality of ThreadedResolver because aiodns did not support getaddrinfo until aio-libs/aiodns#118 see aio-libs#559
AsyncResolver was disabled by default because it did not implement all of functionality of ThreadedResolver because aiodns did not support getaddrinfo until aio-libs/aiodns#118 see #559
AsyncResolver was disabled by default because it did not implement all of functionality of ThreadedResolver because aiodns did not support getaddrinfo until aio-libs/aiodns#118 see aio-libs#559
I just finished the testing for a PR to Looks like we need |
This is a followup to aio-libs#118 to add `getnameinfo` as well to support aio-libs/aiohttp#8270
This is a followup to aio-libs#118 to add `getnameinfo` as well to support aio-libs/aiohttp#8270
This is a followup to #118 to add `getnameinfo` as well to support aio-libs/aiohttp#8270
The end goal is to be able to use this in aiohttp's resolver https://github.com/aio-libs/aiohttp/blob/aa014a9c1084368a01a79f09bb238486e0aa164a/aiohttp/resolver.py#L91 as the current implementation doesn't return both IPv6 and IPv4 addresses which provides different semantics than the threaded resolver which uses python's built-in
getaddrinfo
fixes #23 #23 (comment)
We are going to be rolling out Happy Eyeballs support in
aiohttp
3.10.x so it would be nice to be able to avoid the threads