Add support for getaddrinfo #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
force-pushed
the
ares_getaddrinfo
branch
from
9efd0dd
to
5208bbb
Compare
This was referenced Mar 26, 2024
|
The CI is not happy 😅 |
|
Sorry about that. Should be ok now |
|
Looks like macos can return more than one address so I adjusted the test as well. I created a fork, enabled actions, and verified a clean run bdraco#1 |
|
Cheers! |
|
I'll cut a release tonight. |
|
Thanks |
bdraco
added a commit
to aio-libs/aiohttp
that referenced
this pull request
Mar 30, 2024
AsyncResolver was disabled by default because it did not implement all of functionality of ThreadedResolver because aiodns did not support getaddrinfo until aio-libs/aiodns#118 see #559
8 tasks
bdraco
added a commit
to bdraco/aiohttp
that referenced
this pull request
Mar 30, 2024
AsyncResolver was disabled by default because it did not implement all of functionality of ThreadedResolver because aiodns did not support getaddrinfo until aio-libs/aiodns#118 see aio-libs#559
bdraco
added a commit
to aio-libs/aiohttp
that referenced
this pull request
Mar 30, 2024
AsyncResolver was disabled by default because it did not implement all of functionality of ThreadedResolver because aiodns did not support getaddrinfo until aio-libs/aiodns#118 see #559
bdraco
added a commit
to bdraco/aiohttp
that referenced
this pull request
Mar 30, 2024
AsyncResolver was disabled by default because it did not implement all of functionality of ThreadedResolver because aiodns did not support getaddrinfo until aio-libs/aiodns#118 see aio-libs#559
bdraco
added a commit
to aio-libs/aiohttp
that referenced
this pull request
Mar 30, 2024
AsyncResolver was disabled by default because it did not implement all of functionality of ThreadedResolver because aiodns did not support getaddrinfo until aio-libs/aiodns#118 see #559
bdraco
added a commit
to bdraco/aiohttp
that referenced
this pull request
Mar 30, 2024
AsyncResolver was disabled by default because it did not implement all of functionality of ThreadedResolver because aiodns did not support getaddrinfo until aio-libs/aiodns#118 see aio-libs#559
bdraco
added a commit
to aio-libs/aiohttp
that referenced
this pull request
Mar 30, 2024
AsyncResolver was disabled by default because it did not implement all of functionality of ThreadedResolver because aiodns did not support getaddrinfo until aio-libs/aiodns#118 see #559
bdraco
added a commit
to bdraco/aiohttp
that referenced
this pull request
Mar 30, 2024
AsyncResolver was disabled by default because it did not implement all of functionality of ThreadedResolver because aiodns did not support getaddrinfo until aio-libs/aiodns#118 see aio-libs#559
|
I just finished the testing for a PR to Looks like we need |
bdraco
added a commit
to bdraco/aiodns
that referenced
this pull request
Mar 30, 2024
This is a followup to aio-libs#118 to add `getnameinfo` as well to support aio-libs/aiohttp#8270
bdraco
added a commit
to bdraco/aiodns
that referenced
this pull request
Mar 30, 2024
This is a followup to aio-libs#118 to add `getnameinfo` as well to support aio-libs/aiohttp#8270
saghul
pushed a commit
that referenced
this pull request
Mar 30, 2024
This is a followup to #118 to add `getnameinfo` as well to support aio-libs/aiohttp#8270
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The end goal is to be able to use this in aiohttp's resolver https://github.com/aio-libs/aiohttp/blob/aa014a9c1084368a01a79f09bb238486e0aa164a/aiohttp/resolver.py#L91 as the current implementation doesn't return both IPv6 and IPv4 addresses which provides different semantics than the threaded resolver which uses python's built-in
getaddrinfofixes #23 #23 (comment)
We are going to be rolling out Happy Eyeballs support in
aiohttp3.10.x so it would be nice to be able to avoid the threads