Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Winloop as a valid EventLoop #116

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Add Winloop as a valid EventLoop #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b74e55
add winloop as a valid event loop
Vizonex Mar 21, 2024
576c985
add uvloop and winloop for testing
Vizonex Mar 22, 2024
397a3d8
Update tests.py
Vizonex Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions aiodns/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,14 @@ def __init__(self, nameservers: Optional[Sequence[str]] = None,
assert self.loop is not None
if sys.platform == 'win32':
if not isinstance(self.loop, asyncio.SelectorEventLoop):
raise RuntimeError(
'aiodns needs a SelectorEventLoop on Windows. See more: https://github.com/saghul/aiodns/issues/86')
try:
import winloop
if not isinstance(self.loop , winloop.Loop):
raise RuntimeError(
'aiodns needs a SelectorEventLoop on Windows. See more: https://github.com/saghul/aiodns/issues/86')
except ModuleNotFoundError:
raise RuntimeError(
'aiodns needs a SelectorEventLoop on Windows. See more: https://github.com/saghul/aiodns/issues/86')
kwargs.pop('sock_state_cb', None)
timeout = kwargs.pop('timeout', None)
self._timeout = timeout
Expand Down
18 changes: 18 additions & 0 deletions tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,16 @@

import aiodns

try:
if sys.platform == "win32":
import winloop as uvloop
skip_uvloop = False
else:
import uvloop
skip_uvloop = False
except ModuleNotFoundError:
skip_uvloop = True


class DNSTest(unittest.TestCase):
def setUp(self):
Expand Down Expand Up @@ -162,6 +172,14 @@ def test_gethostbyname_bad_family(self):
# result = self.loop.run_until_complete(f)
# self.assertTrue(result)

@unittest.skipIf(skip_uvloop, "We don't have a uvloop or winloop module")
class TestUV_DNS(DNSTest):
def setUp(self):
asyncio.set_event_loop_policy(uvloop.EventLoopPolicy())
self.loop = asyncio.new_event_loop()
self.addCleanup(self.loop.close)
self.resolver = aiodns.DNSResolver(loop=self.loop, timeout=5.0)
self.resolver.nameservers = ['8.8.8.8']

if __name__ == '__main__':
unittest.main(verbosity=2)
Loading