Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PEP-561 with py.typed #109

Merged
merged 2 commits into from
Oct 15, 2023
Merged

Add PEP-561 with py.typed #109

merged 2 commits into from
Oct 15, 2023

Conversation

JCHacking
Copy link
Contributor

Added the py.typed file so that when someone uses this library they can parse their typed with mypy

This was pointed out in #93

@saghul
Copy link
Contributor

saghul commented Oct 15, 2023

Is there a way to test this?

@JCHacking
Copy link
Contributor Author

The way I realized it was when I wanted to use a library that I had made from another one. So I understand that you can not test from the same library.

@saghul
Copy link
Contributor

saghul commented Oct 15, 2023

I see. I think you need to add it to MANIFEST.in though, so it's added to the package when building it, otherwise it will be skipped.

@JCHacking
Copy link
Contributor Author

@saghul I have already added it, if you can confirm me that this is correct (I have never used MANIFEST.in)

@saghul saghul merged commit 40cb14c into aio-libs:master Oct 15, 2023
19 checks passed
@saghul
Copy link
Contributor

saghul commented Oct 15, 2023

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants