Add notice to windows user with wrong asyncio loop #105
+43
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
requested changes
Feb 20, 2023
saghul
requested changes
Feb 21, 2023
aiodns/__init__.py
Outdated
| @@ -47,6 +48,10 @@ class DNSResolver: | |||
| def __init__(self, nameservers: Optional[List[str]] = None, | |||
| loop: Optional[asyncio.AbstractEventLoop] = None, | |||
| **kwargs: Any) -> None: | |||
| if sys.platform == 'win32': | |||
| if(type(loop) != asyncio.SelectorEventLoop): | |||
saghul
added a commit
that referenced
this pull request
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check user's env to let them know about aiodns needs a SelectorEventLoop on Windows platform.
Updated the example usage.