Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate alls-green in CI/CD #1271

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Conversation

jakob-keller
Copy link
Collaborator

Description of Change

Integrate alls-green in CI/CD

Assumptions

Branch protection rules are updated accordingly

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details): closes Integrate alls-green in CI #1171
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller added the github_actions Pull requests that update GitHub Actions code label Jan 19, 2025
@jakob-keller jakob-keller self-assigned this Jan 19, 2025
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.41%. Comparing base (fb860e8) to head (2c2f499).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1271      +/-   ##
==========================================
- Coverage   87.48%   87.41%   -0.07%     
==========================================
  Files          67       67              
  Lines        5905     5905              
==========================================
- Hits         5166     5162       -4     
- Misses        739      743       +4     
Flag Coverage Δ
unittests 87.41% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller marked this pull request as ready for review January 19, 2025 10:47
@jakob-keller jakob-keller requested a review from webknjaz January 19, 2025 10:47
@webknjaz webknjaz enabled auto-merge January 19, 2025 10:51
@webknjaz webknjaz added this pull request to the merge queue Jan 19, 2025
@jakob-keller
Copy link
Collaborator Author

@webknjaz: Thanks for the review! Could you please also check settings, such as branch protection rules? I don't have access to those.

Merged via the queue into aio-libs:master with commit bdfbfd5 Jan 19, 2025
12 checks passed
@jakob-keller jakob-keller deleted the alls-green branch January 19, 2025 10:59
@webknjaz
Copy link
Member

Sometimes, it's a good idea to delay updating the branch protection rules — only PRs that run CI after this change will report this status. Old PRs don't have this check reported so requiring it would block them until updated.
But up to you, there's not many of them, anyway.

@webknjaz
Copy link
Member

@jakob-keller I can't right now, but I'll try to look into it later. I should probably improve your privileges while on it.

@jakob-keller
Copy link
Collaborator Author

For what it’s worth, my open PRs are all rebased and the remaining ones are more or less stale anyway. I’d say, you’re free to perform the change wherever you see fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate alls-green in CI
2 participants