Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LVIS-92i Train Code issue (?) #38

Open
paolopertino opened this issue Mar 4, 2025 · 0 comments · May be fixed by #39
Open

LVIS-92i Train Code issue (?) #38

paolopertino opened this issue Mar 4, 2025 · 0 comments · May be fixed by #39

Comments

@paolopertino
Copy link

Hello,
I think there is an issue on LVIS-92i dataloader when it is used in train mode. Specifically at line 71 train_cat_ids = list(train_anno.keys()) there is no check if the categories have at least nshot samples (this is instead done in case of validation).

Proposed fix:

train_cat_ids = [i for i in list(train_anno.keys()) if len(train_anno[i]) > self.shot]
paolopertino added a commit to paolopertino/Matcher that referenced this issue Mar 4, 2025
@paolopertino
lvis92_trainset_issue
6fa0a6c 
Fixes aim-uofa#38

Added a check for ensuring each class within the trainset is composed of at least nshot images, otherwise the load_frame function loops indefinitely

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/aim-uofa/Matcher/issues/38?shareId=XXXX-XXXX-XXXX-XXXX).
@paolopertino paolopertino linked a pull request Mar 4, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lvis92_trainset_issue paolopertino/Matcher
1 participant
@paolopertino