-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename job history and convert the button to a link to a new tab #995
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #995 +/- ##
==========================================
- Coverage 68.59% 68.40% -0.19%
==========================================
Files 111 111
Lines 6304 6293 -11
==========================================
- Hits 4324 4305 -19
- Misses 1980 1988 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
from IPython.display import Javascript | ||
|
||
url = "./calculation_history.ipynb" | ||
display(Javascript(f"window.open('{url}', '_blank')")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #988. I think this will run into a similar issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @superstar54. Looks good and works on my end. A few comments:
-
We'll have to figure out another approach for linking to another notebook to avoid browser pop-up blocker (The "Start new calculation" button gets blocked by a pop-up blocker #988)
-
Need a space between Quantum and ESPRESSO in the notebook title
-
Could we make the table expand to full page width?
Hi @edan-bainglass , thanks for the review.
Do you know how to do this? I tried Update: use the same CSS style as the main app solve the issue. |
Hi @edan-bainglass ,
Yes. I fixed another two issues. Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. LGTM! Thanks @superstar54. I'll look into the pop-up blocker issue today. Once I have a fix, I can also apply it to your button.
Fix #996
Fix #997
Job history
toCalculation history