Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename job history and convert the button to a link to a new tab #995

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Dec 18, 2024

Fix #996
Fix #997

  • Rename Job history to Calculation history
  • Convert the button to a link to a new tab

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.40%. Comparing base (dcb7c93) to head (bd32462).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/aiidalab_qe/app/wrapper.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #995      +/-   ##
==========================================
- Coverage   68.59%   68.40%   -0.19%     
==========================================
  Files         111      111              
  Lines        6304     6293      -11     
==========================================
- Hits         4324     4305      -19     
- Misses       1980     1988       +8     
Flag Coverage Δ
python-3.11 68.39% <50.00%> (-0.20%) ⬇️
python-3.9 68.43% <50.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

from IPython.display import Javascript

url = "./calculation_history.ipynb"
display(Javascript(f"window.open('{url}', '_blank')"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #988. I think this will run into a similar issue.

Copy link
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @superstar54. Looks good and works on my end. A few comments:

image

@superstar54
Copy link
Member Author

superstar54 commented Dec 18, 2024

Hi @edan-bainglass , thanks for the review.

Could we make the table expand to full page width?

Do you know how to do this? I tried ipw.Layout(width="100%"), but it does not work.

Update: use the same CSS style as the main app solve the issue.

@superstar54
Copy link
Member Author

Hi @edan-bainglass ,

We'll have to figure out another approach for linking to another notebook to avoid browser pop-up blocker

Yes.

I fixed another two issues. Please review.

Copy link
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. LGTM! Thanks @superstar54. I'll look into the pop-up blocker issue today. Once I have a fix, I can also apply it to your button.

@superstar54 superstar54 merged commit b288780 into aiidalab:main Dec 19, 2024
7 of 8 checks passed
@superstar54 superstar54 deleted the rename_job_history branch December 19, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants