Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more details on how we computed the min cpus #972

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

mikibonacci
Copy link
Member

This fixes #887

Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.40%. Comparing base (b288780) to head (7d84cb1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #972   +/-   ##
=======================================
  Coverage   68.40%   68.40%           
=======================================
  Files         111      111           
  Lines        6293     6293           
=======================================
  Hits         4305     4305           
  Misses       1988     1988           
Flag Coverage Δ
python-3.11 68.40% <ø> (+0.01%) ⬆️
python-3.9 68.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikibonacci mikibonacci merged commit 9e2f4b5 into aiidalab:main Dec 19, 2024
4 of 7 checks passed
@mikibonacci mikibonacci deleted the fix/estimate_min_cpus branch December 19, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain how the (useful!) _estimate_min_cpus was defined?
2 participants