Fix code_widget_class for PW #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #938 +/- ##
==========================================
+ Coverage 68.04% 68.05% +0.01%
==========================================
Files 104 104
Lines 5793 5795 +2
==========================================
+ Hits 3942 3944 +2
Misses 1851 1851
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
edan-bainglass
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
LGTM @superstar54. As discussed, just add the defaults and this is good to go 💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used
PwCodeModel, but got an error that there is noparallelizationwidget. Then I learned that I need to passPwCodeResourceSetupWidgetas thecode_widget_class.It would be good to make
PwCodeResourceSetupWidgetdefaultcode_widget_classforPwCodeModel.