Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore update results button functionality #924

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

edan-bainglass
Copy link
Member

The logic of the update results button was missed in #921. This PR restores the functionality by adding a refresh parameter to the _update_node_view method to allow bypassing the node view cache.

Note: a follow-up PR is planned to rethink the way we deal with the WorkChainViewer tabs which will render the update results button redundant.

Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the fix!

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.94%. Comparing base (5a55a5c) to head (8ccae82).
Report is 126 commits behind head on main.

Files with missing lines Patch % Lines
src/aiidalab_qe/app/result/__init__.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #924      +/-   ##
==========================================
+ Coverage   66.92%   66.94%   +0.01%     
==========================================
  Files          51       51              
  Lines        4726     4725       -1     
==========================================
  Hits         3163     3163              
+ Misses       1563     1562       -1     
Flag Coverage Δ
python-3.11 66.94% <33.33%> (+0.01%) ⬆️
python-3.9 66.97% <33.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edan-bainglass edan-bainglass merged commit 150b22e into aiidalab:main Nov 11, 2024
8 checks passed
edan-bainglass added a commit to edan-bainglass/aiidalab-qe that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants