Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing nan from properties query #906

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

AndresOrtegaGuerrero
Copy link
Member

This PR fixes #905

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.15%. Comparing base (b0cfdbd) to head (3a35ed9).
Report is 115 commits behind head on main.

Files with missing lines Patch % Lines
src/aiidalab_qe/app/utils/search_jobs.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #906   +/-   ##
=======================================
  Coverage   67.15%   67.15%           
=======================================
  Files          51       51           
  Lines        4707     4707           
=======================================
  Hits         3161     3161           
  Misses       1546     1546           
Flag Coverage Δ
python-3.11 67.15% <0.00%> (ø)
python-3.9 67.18% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Also interesting to see which calculation has property as None, and what the issue there.

@AndresOrtegaGuerrero AndresOrtegaGuerrero merged commit 15f46b0 into main Oct 28, 2024
12 checks passed
@AndresOrtegaGuerrero AndresOrtegaGuerrero deleted the fix_905_nan_description branch October 28, 2024 11:04
edan-bainglass pushed a commit to edan-bainglass/aiidalab-qe that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug report: Application crashed with TraitError
2 participants