Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the structure optimized info in the workflow summary #882

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

mikibonacci
Copy link
Member

This fixes #878

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.06%. Comparing base (61b831c) to head (908a560).
Report is 123 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #882   +/-   ##
=======================================
  Coverage   67.06%   67.06%           
=======================================
  Files          51       51           
  Lines        4715     4715           
=======================================
  Hits         3162     3162           
  Misses       1553     1553           
Flag Coverage Δ
python-3.11 67.06% <ø> (ø)
python-3.9 67.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikibonacci mikibonacci merged commit d4da2d4 into aiidalab:main Nov 6, 2024
5 of 7 checks passed
@mikibonacci mikibonacci deleted the fix/structure_optimized_info branch November 6, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

it still says “structure optimized -> Yes” even if I select “as is”
2 participants