Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update labels for fat_bands #842

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

AndresOrtegaGuerrero
Copy link
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero commented Oct 7, 2024

In #787 ,
I forgot to update the logic for the fat_bands , here is included
Now for only bands calculations and fat bands the labels are propertly display
image

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 68.07%. Comparing base (860f59b) to head (1ba25e3).
Report is 88 commits behind head on main.

Files with missing lines Patch % Lines
src/aiidalab_qe/common/bandpdoswidget.py 25.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
- Coverage   68.12%   68.07%   -0.05%     
==========================================
  Files          50       50              
  Lines        4555     4561       +6     
==========================================
+ Hits         3103     3105       +2     
- Misses       1452     1456       +4     
Flag Coverage Δ
python-3.11 68.07% <25.00%> (-0.05%) ⬇️
python-3.9 68.10% <25.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mikibonacci mikibonacci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AndresOrtegaGuerrero , for me can be merged! We should keep in mind to have some tests in the future, but for now it is not so crucial.

Thanks!

@AndresOrtegaGuerrero AndresOrtegaGuerrero merged commit 4c19d24 into main Oct 7, 2024
12 checks passed
@AndresOrtegaGuerrero AndresOrtegaGuerrero deleted the fix/bandswidget_fatbands_labels_bands branch October 7, 2024 16:19
edan-bainglass pushed a commit to edan-bainglass/aiidalab-qe that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants