Add slider to adjust fat bands width #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A slider is added to the `BandPdosWidget` to enable the control of the fat bands width. This is necessary as different bandstructures require a different resolution.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #808 +/- ##
==========================================
- Coverage 68.79% 68.76% -0.04%
==========================================
Files 49 49
Lines 4243 4245 +2
==========================================
Hits 2919 2919
- Misses 1324 1326 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AndresOrtegaGuerrero
approved these changes
Sep 24, 2024
edan-bainglass
pushed a commit
to edan-bainglass/aiidalab-qe
that referenced
this pull request
Oct 24, 2024
A slider is added to the `BandPdosWidget` to enable the control of the fat bands width. This is necessary as different bandstructures require a different resolution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AndresOrtegaGuerrero as discussed, I added a slider to control the width of the fat bands. It will only become visible once you enable the fat bands. In agreement with the previous logic, you need to click the update button to adjust the width. The slider covers a range from 10 to 750 meV/atom as the maximum width of a fat band.