Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaning 2D path logic #725

Merged
merged 2 commits into from
May 10, 2024
Merged

cleaning 2D path logic #725

merged 2 commits into from
May 10, 2024

Conversation

AndresOrtegaGuerrero
Copy link
Member

This PR solves an issue that can occurs with working with oblique cell, where due to rounding number it will not include a k-point.

If you want to reproduce the issue with the current app, use
structure-not-stored (25).cif.zip

@AndresOrtegaGuerrero AndresOrtegaGuerrero added the bug Something isn't working label May 10, 2024
Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@AndresOrtegaGuerrero AndresOrtegaGuerrero merged commit 9ed3337 into main May 10, 2024
18 checks passed
@AndresOrtegaGuerrero AndresOrtegaGuerrero deleted the fix/bug_oblique branch May 10, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants