Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide get_workchain_metadata help function #1173

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Feb 19, 2025

This PR adds another help function get_workchain_metadata function to tell the app how many calcjobs (estimation) will be submitted in the workchain. This is useful to show the progress in the workflow.

Note: we have many help functions in the workchain entry, and it would be better to provide a class to wrap all of them together in the future.

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.98%. Comparing base (6228414) to head (e9a5579).

Files with missing lines Patch % Lines
src/aiidalab_qe/plugins/bands/workchain.py 66.66% 1 Missing ⚠️
src/aiidalab_qe/plugins/pdos/workchain.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1173      +/-   ##
==========================================
- Coverage   72.99%   72.98%   -0.01%     
==========================================
  Files          94       94              
  Lines        6532     6538       +6     
==========================================
+ Hits         4768     4772       +4     
- Misses       1764     1766       +2     
Flag Coverage Δ
python-3.11 72.97% <66.66%> (-0.03%) ⬇️
python-3.9 72.99% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 force-pushed the number_of_calcjob branch 3 times, most recently from 3c8d58d to 0499d0a Compare February 19, 2025 11:00
@superstar54 superstar54 marked this pull request as draft February 19, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant