-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XAS: Migrate XAS App to New Repository #1139
XAS: Migrate XAS App to New Repository #1139
Conversation
Removes the XAS app from the AiiDAlab-QE repository as part of migrating the app to `aiidaplugins/aiida-qe-xspec`.
@superstar54 I updated the description for the XSpec plugin (both the title and GitHub repo) since I noticed the details were not quite correct. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1139 +/- ##
==========================================
+ Coverage 71.94% 73.68% +1.73%
==========================================
Files 105 94 -11
Lines 6886 6433 -453
==========================================
- Hits 4954 4740 -214
+ Misses 1932 1693 -239
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -21,9 +21,9 @@ aiidalab-qe-muon: | |||
github: https://github.com/mikibonacci/aiidalab-qe-muon | |||
|
|||
aiida-qe-xspec: | |||
title: XPS (aiida-qe-xspec) | |||
title: Core-level spectroscopy (aiida-qe-xspec) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good also include XAS/XPS in the title so people know it immedinately, how about:
XAS/XPS core-level spectroscopy (aiida-qe-xspec)
- or,
Core-level spectroscopy for XAS/XPS (aiida-qe-xspec)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are fields for title
and description
, I would go with:
aiida-qe-xspec:
title: Core-level spectroscopy (aiida-qe-xspec)
description: XAS and XPS calculations with Quantum ESPRESSO.
author: Xing Wang, Peter Gillespie
github: https://github.com/aiidalab/aiida-qe-xspec
github: https://github.com/aiidaplugins/aiida-qe-xspec
documentation: https://aiida-qe-xspec.readthedocs.io/
pip: aiida-qe-xspec
Let me know if that's acceptable, and I will update the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Removes the XAS app from the AiiDAlab-QE repository as part of migrating the app to
aiidaplugins/aiida-qe-xspec
.Additionally updates some minor details of the
aiida-qe-xspec
entry ofplugins.yaml
.