Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply button color class to LinkButton widget, not its internal anchor tag #1135

Merged

Conversation

edan-bainglass
Copy link
Member

Fixes an issue with button styles

@edan-bainglass edan-bainglass self-assigned this Feb 3, 2025
Copy link
Member

@mikibonacci mikibonacci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.99%. Comparing base (9807738) to head (78470fd).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1135   +/-   ##
=======================================
  Coverage   71.98%   71.99%           
=======================================
  Files         105      105           
  Lines        6876     6878    +2     
=======================================
+ Hits         4950     4952    +2     
  Misses       1926     1926           
Flag Coverage Δ
python-3.11 71.99% <100.00%> (+<0.01%) ⬆️
python-3.9 72.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edan-bainglass edan-bainglass force-pushed the fix-examples-link-style branch from 9156557 to 78470fd Compare February 3, 2025 16:27
@edan-bainglass edan-bainglass merged commit d565d43 into aiidalab:main Feb 3, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants