Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement logging widget (mostly for devs) #1133

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

edan-bainglass
Copy link
Member

@edan-bainglass edan-bainglass commented Feb 3, 2025

This PR adds a flag, which if True, adds an Output widget at the bottom of the app, accompanied by a reset button. The widget can then be passed down to any part of the app that needs to be tested.
The PR hardcodes one use-case - monitoring. The ProcessMonitor was recently changed (aiidalab/aiidalab-widgets-base#669) to accept an output widget and use it to log exceptions in monitored callbacks. This PR passes the output widget (if included) down to the ProcessMonitor instance, exposing its exceptions. This is useful for debugging issues in the results step.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 71.92%. Comparing base (e3e7816) to head (805ddab).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/aiidalab_qe/app/main.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1133      +/-   ##
==========================================
- Coverage   71.99%   71.92%   -0.07%     
==========================================
  Files         105      105              
  Lines        6877     6886       +9     
==========================================
+ Hits         4951     4953       +2     
- Misses       1926     1933       +7     
Flag Coverage Δ
python-3.11 71.92% <27.27%> (-0.07%) ⬇️
python-3.9 71.93% <27.27%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edan-bainglass edan-bainglass force-pushed the dev-log branch 2 times, most recently from b60c4f1 to 96fe1c1 Compare February 4, 2025 05:08
Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful! thanks!

@edan-bainglass edan-bainglass merged commit 7bea74e into aiidalab:main Feb 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants