Use the XPS plugin from aiida-qe-xspec #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the XPS plugin from the core - Remove the related tests - Update plugins.yaml
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1127 +/- ##
==========================================
+ Coverage 71.05% 72.48% +1.42%
==========================================
Files 115 105 -10
Lines 7159 6810 -349
==========================================
- Hits 5087 4936 -151
+ Misses 2072 1874 -198
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Ping @PNOGillespie , because he will open a similar PR for the XAS plugin. |
|
@mikibonacci has experience registering plugins from outside the app; please review the PR. thanks! |
mikibonacci
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XPS is migrated to a new repository: https://github.com/aiidalab/aiida-qe-xspec, this will make the maintenance easy and flexible.
This PR
Note: I still keep the docs, because I think it is very useful to have a doc on the qeapp's page.