Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify raw data / archive download message #1116

Merged

Conversation

edan-bainglass
Copy link
Member

@edan-bainglass edan-bainglass commented Jan 30, 2025

Change message to clarify that the waiting time is due to AiiDA creating the file, not the user's network.

Closes #1109

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.94%. Comparing base (5a32a7b) to head (41a083e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
..._qe/app/result/components/summary/download_data.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1116   +/-   ##
=======================================
  Coverage   70.94%   70.94%           
=======================================
  Files         115      115           
  Lines        7158     7158           
=======================================
  Hits         5078     5078           
  Misses       2080     2080           
Flag Coverage Δ
python-3.11 70.94% <0.00%> (ø)
python-3.9 70.93% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edan-bainglass edan-bainglass merged commit 2249780 into aiidalab:main Jan 30, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Say "Creating file to download" rather than "Downloading file" when clicking on the two download buttons
2 participants