Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable download button when clicked, until the download starts #977

Closed
mikibonacci opened this issue Dec 16, 2024 · 0 comments · Fixed by #978
Closed

Disable download button when clicked, until the download starts #977

mikibonacci opened this issue Dec 16, 2024 · 0 comments · Fixed by #978
Assignees

Comments

@mikibonacci
Copy link
Member

Since it takes times to create the .zip or the .aiida, people might click multiple times.

Also, I would write "Generating file to be downloaded, please be patient..." rather than "Downloading..."

@mikibonacci mikibonacci self-assigned this Dec 16, 2024
edan-bainglass added a commit that referenced this issue Dec 19, 2024
This PR redesigns step 4 as follows:

- Split step into three "tabs":
  - Parameters summary and data download controls
  - Result panels
  - Process status views
    - "simplified" view (to be implemented in a later PR), and
    - "advanced" view (the current process tree)
- Smoothly handle transition from submission to results - the app now proceeds to step 4 while the builder is created and submitted. Step 4 is updated once the process is ready (Submit button doesn't get immediately disabled and it might take 2-3 seconds to go to next step #994)
  - Also resolves the issue where the submit button can be repeatedly pressed
- Discard redundant "Update results" button
- Disable raw-data/archive download buttons when downloading (Disable download button when clicked, until the download starts #977)
- Inject process pk to url on submission (Change URL when calc is submitted (and PK is assigned) #990)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant