fix: implementation of useSyncExternalStore #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SukkaW
reviewed
Jan 10, 2023
packages/react/hooks.ts
Outdated
Comment on lines
247
to
254
| // This implementation is grokked straight from Preact (ref: https://github.com/preactjs/preact/blob/528a7760c1cdec7515d514c71875860528e6dc12/compat/src/index.js#L142-L171) | ||
| // (c) 2015-present Jason Miller | ||
| export const useSyncExternalStore = (subscribe, getSnapshot) => { | ||
| const [state, setState] = useState(getSnapshot); | ||
|
|
||
| const value = getSnapshot(); | ||
|
|
||
| useLayoutEffect(() => { | ||
| if (value !== state) { | ||
| setState(() => value); | ||
| } | ||
| }, [subscribe, value, getSnapshot]); | ||
| const [{ instance }, forceUpdate] = useState({ | ||
| instance: { value, getSnapshot } | ||
| }); |
There was a problem hiding this comment.
It looks like preact's new useSyncExternalStore is now ported from react's use-sync-external-store/shim. So you should do it too.
Please do copy their comments describing how it breaks rule of hooks. Million.js doesn't have concurrent rendering (Both preact and Million.js performs synchronous rendering just like React pre-18), and it is the only reason why react's shim also works for Million.js (and preact).
SukkaW
approved these changes
Jan 10, 2023
|
Thanks for your contribution! I have just approved the CI. |
Pull Request Test Coverage Report for Build 3885856542
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Status
Semantic versioning classification:
This PR updates the hook implementation used by
preact.Refs: preactjs/preact#3663 and preactjs/preact@528a776