Include error message when error raised by object macro #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the error message in the response when error is raised within an object macro.
When an error is raised in an object, the error message is included along with the default error response, e.g.
[ERR: Error when executing JavaScript object: TypeError]. Very useful for debugging & testing!However, when an error is raised in an async object macro, instead of returning the above default error reply, it only returns
[ERR: Error raised by object macro]. Adding error message to follow similar pattern above.Test added to cover this.
👉 Take note of the misspelling in the tests of
asycthat was preventing await tests from running.