Add contract tests #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They all really need the same test to start: execute fails when called directly. Importing error codes to avoid setting them again, so far since each proposal is keyed to one contract doesn't look like an issue.
One challenge with this structure if we have to instantiate the dao before running every test. These helper methods should allow us to meet all the criteria to pass proposals and test their result, and we can verify other values along the way.
Haven't narrowed down the exact bug but can continue making the generalized proposal functions now that flow is confirmed.
Importing between test files is a no no
That way we can use same enum, same outcome
Merges some other minor changes, one test passing each should be ready to translate to the templates for testnet.
give a little time for liquidity
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic tests for all but the token, token-dex, and bitflow-pool contracts as those were externally sourced.
Will continue to add more around proposals next.