Feat/voting power #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This greatly simplifies things as we can drop in template values where needed vs trying to initialize everything after the fact and require calling functions with extra information, e.g. trait contracts. From here we can review how to calculate liquid balance at proposal block, then complete the voting logic.
This hardcodes them for the purpose we're using them for, and they can be extended/upgraded/changed out in the future. This way the voting calculations are not in flux if something changes, and we can use the templates to provide the correct contract names when generating the contracts.
This was a one-off shot at adding tests and def would fix a few things, going to set a standard on the first few then iterate, as well as focus on key elements.
Still leaves some boilerplate this should be tested language for what wouldve been empty files, otherwise removes blank checks that were hints to what tests should be run. Can pass through again and turn them back on.
This version works with the test, the clarinet check version causes problems for some reason. Shouldn't be an issue in GH action.
|
Updated calculation in each proposal contract for: This will make both voting extensions valid before and after the DEX graduates. Changing the target pool or providing liquidity after graduation may affect this extension and require some modification / replacement. Also cleaned up the test files to get everything at a clear starting point. Next PR let's add tests to verify everything is working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
total supply - tokens in treasury - tokens in dex