Prepare fv3net for open sourcing #1090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is GPL, and not really needed
oliverwm1
approved these changes
Mar 17, 2021
Contributor
oliverwm1
left a comment
oliverwm1
left a comment
There was a problem hiding this comment.
LGTM, thanks! Side note: is there something non-deterministic about generating the constraints.txt file? Or does it depend on local env? There are a few packages that seem to appear and disappear depending on who touched it last.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cherry-picked the relevant changes from #986. We can upgrade to python 3.7 and the newer cftime/xarray at a later date.
Resolves #920.