-
Notifications
You must be signed in to change notification settings - Fork 177
BUILD: Add meson option for selective plugin building #951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
👋 Hi michal-shalev! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
Signed-off-by: Michal Shalev <[email protected]>
f48b266 to
b91ad63
Compare
|
Seems to be useful |
| option('cudapath_lib', type: 'string', value: '', description: 'Library path for CUDA') | ||
| option('cudapath_stub', type: 'string', value: '', description: 'Extra Stub path for CUDA') | ||
| option('static_plugins', type: 'string', value: '', description: 'Plugins to be built-in, comma-separated') | ||
| option('build_plugins', type: 'string', value: '', description: 'List of plugins to build, comma-separated. Default (empty) builds all available plugins') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we name this plugins?
| build_plugins_opt = get_option('build_plugins') | ||
| enabled_plugins = build_plugins_opt == '' ? [] : build_plugins_opt.split(',') | ||
|
|
||
| should_build_plugin = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should_build_plugin should be called enabled_plugins IMO
| enabled_plugins = build_plugins_opt == '' ? [] : build_plugins_opt.split(',') | ||
|
|
||
| should_build_plugin = {} | ||
| foreach plugin : ['UCX', 'UCX_MO', 'LIBFABRIC', 'POSIX', 'OBJ', 'GDS', 'GDS_MT', 'MOONCAKE', 'Mooncake', 'HF3FS', 'GUSLI', 'GPUNETIO'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make a list all_plugins and do case insensitive comparison to avoid duplicates
|
@michal-shalev thanks for adding this. I think we can take a little bit better approach: |
What?
Add a new
build_pluginsmeson option to selectively build only specific plugins instead of all available plugins.Why?
Building all plugins increases build time and requires all plugin dependencies to be present. When developing or deploying with only specific plugins (e.g., just UCX), building unnecessary plugins wastes time and resources. This option allows users to:
How?
build_pluginsmeson option that accepts a comma-separated list of plugin names (e.g.,UCX,GPUNETIO)should_build_plugindictionary that is computed once in the mainmeson.buildand used throughoutsrc/plugins/meson.build- only builds requested plugin librariestest/unit/plugins/meson.build- only builds unit tests for enabled pluginstest/gtest/plugins/meson.build- skips if required plugins aren't enabledUsage examples: