CI: Add EFA security group validation and pre-flight check - #832
Merged
Merged
Conversation
|
👋 Hi Alexey-Rivkin! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
Alexey-Rivkin
force-pushed
the
efa_sec_group
branch
from
September 28, 2025 12:13
dac7814 to
7bfeaf7
Compare
Alexey-Rivkin
force-pushed
the
efa_sec_group
branch
from
September 28, 2025 14:24
7bfeaf7 to
865f9a9
Compare
Alexey-Rivkin
force-pushed
the
efa_sec_group
branch
from
September 28, 2025 14:39
865f9a9 to
a24b3a9
Compare
AWS EFA requires self-referencing security group rules for inter-node communication. Add verification commands to README and integrate fi_pingpong validation into aws_test.sh to fail fast if EFA is misconfigured. Signed-off-by: Alexey Rivkin <arivkin@nvidia.com>
Alexey-Rivkin
force-pushed
the
efa_sec_group
branch
from
September 28, 2025 15:00
a24b3a9 to
cbb5d7e
Compare
Contributor
Author
|
/build |
Alexey-Rivkin
marked this pull request as ready for review
September 28, 2025 15:24
Alexey-Rivkin
changed the title
brminich
reviewed
Sep 29, 2025
ovidiusm
approved these changes
Sep 29, 2025
brminich
approved these changes
Sep 29, 2025
mkhazraee
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Why?
AWS requires specific security group configs for EFA. Need validation to ensure libfabric EFA provider works.
How?
fi_info -p efacheck in aws_test.sh (fails fast if EFA unavailable)Note: Using
fi_infoinstead offi_pingpongsince latter requires multi-node setup.