Flush out commQueue before stopping listener #830
+18
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi 2dm! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
|
/ok to test 458e800 |
|
/build |
2dm
force-pushed
the
destructor-race
branch
from
458e800 to
f30a139
Compare
2dm
force-pushed
the
destructor-race
branch
from
f30a139 to
7a7cdb7
Compare
|
/ok to test 7a7cdb7 |
|
/build |
mkhazraee
reviewed
Sep 27, 2025
2dm
force-pushed
the
destructor-race
branch
from
7a7cdb7 to
3b82789
Compare
|
/build |
|
/ok to test 99297c6 |
|
/build |
aranadive
reviewed
Oct 7, 2025
Co-authored-by: Adit Ranadive <[email protected]> Signed-off-by: Micha Dery <[email protected]>
aranadive
approved these changes
Oct 8, 2025
|
/ok to test 4387963 |
|
/build |
|
/build |
1 similar comment
|
/build |
ovidiusm
reviewed
Oct 9, 2025
|
|
||
| nixlAgent::~nixlAgent() { | ||
| if (data && (data->useEtcd || data->config.useListenThread)) { | ||
| data->agentShutdown = true; |
There was a problem hiding this comment.
IIUC agentShutdown is accessed from different threads, it should be atomic
There was a problem hiding this comment.
@ovidiusm Same for commThreadStop then?
|
I still see 2 tests failing with SIGPIPE during cleanup, so I would try to stress test this locally to make sure there is no issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Verify that all enqueued work has completed.
Why?
There is a race between the agent destructor and jobs on
commQueuesince the background thread might finish without checking for existing work in the queue. In particular, the missed job is probablyinvalidateLocalMDthat is called right before, which will keep the MD intact and prevent the re-addition of that rank later.How?
commThreadStop