DEVICE/API: Remove deviceMemList class and simplify create/release GPU request handle - #798
Merged
michal-shalev merged 5 commits intoSep 16, 2025
Conversation
Signed-off-by: Michal Shalev <mshalev@nvidia.com>
michal-shalev
requested review from
brminich,
gleon99 and
yosefe
as code owners
September 16, 2025 15:11
|
👋 Hi michal-shalev! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
Contributor
Author
|
/build |
rakhmets
reviewed
Sep 16, 2025
yosefe
previously approved these changes
Sep 16, 2025
rakhmets
reviewed
Sep 16, 2025
rakhmets
reviewed
Sep 16, 2025
rakhmets
previously approved these changes
Sep 16, 2025
rakhmets
previously approved these changes
Sep 16, 2025
Signed-off-by: Michal Shalev <mshalev@nvidia.com>
Contributor
Author
|
/build |
rakhmets
approved these changes
Sep 16, 2025
yosefe
approved these changes
Sep 16, 2025
yosefe
enabled auto-merge (squash)
September 16, 2025 17:57
brminich
approved these changes
Sep 16, 2025
michal-shalev
changed the title
michal-shalev
disabled auto-merge
September 16, 2025 18:06
michal-shalev
enabled auto-merge (squash)
September 16, 2025 18:06
Contributor
Author
|
/build |
1 similar comment
Contributor
Author
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Decided to revert to 247e211 since it's simpler and the
deviceMemListclass requires to add mapping to gpu req handle to release it.