NIXLBENCH: Set RW sync mode for UCX when num_threads > 1 - #686
Merged
brminich merged 2 commits intoAug 14, 2025
Merged
Conversation
iyastreb
requested review from
a team,
aranadive,
brminich and
ovidiusm
as code owners
August 13, 2025 15:14
|
👋 Hi iyastreb! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
brminich
requested changes
Aug 13, 2025
brminich
reviewed
Aug 13, 2025
brminich
approved these changes
Aug 13, 2025
Contributor
|
/build |
aranadive
approved these changes
Aug 14, 2025
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
nixlbench crashes with UCX backend when
--num_threads> 1Why?
NIXL sets proper UCX worker lock mode only when progress thread is set (
--enable_ptoption), but not when multiple threads are being used.