PYTHON-PROJECT-WIDE: replaced prints with a logger, fixed backtraces - #633
Merged
Merged
Conversation
…ynamo#512) * PYTHON-PROJECT-WIDE: replaced print() calls with proper logging Signed-off-by: Roie Danino <rdanino@nvidia.com> * BENCHMARK/KVBENCH: fixed identations Signed-off-by: Roie Danino <rdanino@nvidia.com> * SRC/API/PYTHON: added a configuration file and a centrelized nixl_logging script with support for NIXL_LOG_LEVEL env Signed-off-by: Roie Danino <rdanino@nvidia.com> * NIXL_LOGGING: remove trailing spaces, fix identations Signed-off-by: Roie Danino <rdanino@nvidia.com> * EXAMPLES/PYTHON: fixed logging imports Signed-off-by: Roie Danino <rdanino@nvidia.com> * BENCHMARK/KVBENCH: fixed logging imports Signed-off-by: Roie Danino <rdanino@nvidia.com> * BENCHMARK/KVBENCH/COMMANDS: fixed blank lines Signed-off-by: Roie Danino <rdanino@nvidia.com> * EXAMPLES/PYTHON: fixed blank lines Signed-off-by: Roie Danino <rdanino@nvidia.com> * SRC/API/PYTHON: moved nixl_logging.py to api/python Signed-off-by: Roie Danino <rdanino@nvidia.com> * BENCHMARK/KVBENCH: fixed identations and blank lines Signed-off-by: Roie Danino <rdanino@nvidia.com> * BENCHMARK/KVBENCH: fixed identations and spaces Signed-off-by: Roie Danino <rdanino@nvidia.com> * BENCHMARK/KVBENCH: fixed identations and spaces Signed-off-by: Roie Danino <rdanino@nvidia.com> * BENCHMARK/KVBENCH: fixed identations and spaces Signed-off-by: Roie Danino <rdanino@nvidia.com> * CONTRIB: install nixl python package in manylinux docker Signed-off-by: Roie Danino <rdanino@nvidia.com> * CONTRIB: moved up installing nixl package Signed-off-by: Roie Danino <rdanino@nvidia.com> * .GITLAB: added a CI step for checking there are no print() in the code and only logger is being used Signed-off-by: Roie Danino <rdanino@nvidia.com> * .GITLAB: added missing copyrights Signed-off-by: Roie Danino <rdanino@nvidia.com> * TEST/PYTHON: change debug logs to info, move script to .ci/scripts Signed-off-by: Roie Danino <rdanino@nvidia.com> * EAMPLES/PYTHON: fix pre-commit checks Signed-off-by: Roie Danino <rdanino@nvidia.com> * TEST/PYTHON: fixed '-' * 40 log lines Signed-off-by: Roie Danino <rdanino@nvidia.com> * EXAMPLES/PYTHON: merge log lines Signed-off-by: Roie Danino <rdanino@nvidia.com> * CONTRIB/MANYLINUX: removed unnecessary pip install Signed-off-by: Roie Danino <rdanino@nvidia.com> * EXAMPLES/PYTHON: fixed formatting Signed-off-by: Roie Danino <rdanino@nvidia.com> * CONTRIB: added back the installtion of the nixl pack in manylinux docker Signed-off-by: Roie Danino <rdanino@nvidia.com> * CONTRIB: can't assume nixl package was installed in a script within contrib folder Signed-off-by: Roie Danino <rdanino@nvidia.com> * CONTRIB: moved import logging below hashlib Signed-off-by: Roie Danino <rdanino@nvidia.com> * .CI/SCRIPTS: added port selection script as test_cpp and test_python might run in parallel Signed-off-by: Roie Danino <rdanino@nvidia.com> * .CI/SCRIPTS: make server_port.sh executable Signed-off-by: Roie Danino <rdanino@nvidia.com> * .CI/SCRIPTS: removed server_port.sh, lets keep it out of this PR Signed-off-by: Roie Danino <rdanino@nvidia.com> * BENCHMAKR/KVBENCH: log -> logger for consistency Signed-off-by: Roie Danino <rdanino@nvidia.com> * API/PYTHON: simplified logging.py code, and minor fixes Signed-off-by: Roie Danino <rdanino@nvidia.com> * SRC/API/PYTHON: replaced format strings with %s formatting in logger lines Signed-off-by: Roie Danino <rdanino@nvidia.com> * BENCHMARK/KVBENCH: replaced all logging line f-strings with % formatting (optimization/compatibility) Signed-off-by: Roie Danino <rdanino@nvidia.com> --------- Signed-off-by: Roie Danino <rdanino@nvidia.com> Co-authored-by: Yossi Itigin <yosefe@nvidia.com> (cherry picked from commit 29ae0ad)
Signed-off-by: Roie Danino <rdanino@nvidia.com>
roiedanino
requested review from
a team,
aranadive,
brminich and
ovidiusm
as code owners
July 29, 2025 10:30
|
👋 Hi roiedanino! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
Signed-off-by: Roie Danino <rdanino@nvidia.com>
Contributor
Author
|
/build |
…CI on tracebacks Signed-off-by: Roie Danino <rdanino@nvidia.com>
Signed-off-by: Roie Danino <rdanino@nvidia.com>
Contributor
Author
|
/build |
Contributor
Author
|
/build |
roiedanino
enabled auto-merge (squash)
August 3, 2025 09:25
Contributor
Author
ovidiusm
reviewed
Aug 6, 2025
ovidiusm
reviewed
Aug 6, 2025
ovidiusm
reviewed
Aug 6, 2025
Signed-off-by: Roie Danino <rdanino@nvidia.com>
Contributor
Author
|
/build |
o90o
approved these changes
Aug 11, 2025
ovidiusm
approved these changes
Aug 11, 2025
dpressle
approved these changes
Aug 11, 2025
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixed #512 by removing hostname from logger format
Why?
PR was merged and reverted due to traceback prints flooding python examples output