[CI] Add new CI test to detect large PRs - #627
Merged
Merged
Conversation
yosefe
reviewed
Jul 28, 2025
Contributor
Author
|
/build |
yosefe
reviewed
Aug 4, 2025
Contributor
|
@aranadive @barneuman @w1ldptr can you pls take a look if have agree with this approach in principle ? |
Contributor
I don't see much value in this automation since code owners are already free to reject all PRs marked as XXL, for example. But I'm not opposed to this either, assuming the check won't become "Required". |
yosefe
enabled auto-merge (squash)
August 10, 2025 17:21
yosefe
disabled auto-merge
August 10, 2025 17:22
dpressle
force-pushed
the
check_pr_size
branch
from
August 13, 2025 06:33
4c30169 to
2431b69
Compare
Limit for single PR should be 500 chnaged lines Signed-off-by: Daniel Pressler <danielpr@nvidia.com>
yosefe
approved these changes
Aug 14, 2025
Contributor
|
/build |
This was referenced Sep 8, 2026
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limit for single PR should be 500 added lines, except subprojects and new files.
What?
Add CI check for PR changed line number
Why?
We want to avoid very large PRs
How?
Add github workflow to detect large PRs