Nixlbench: build in release mode by default in container - #614
Merged
Merged
Conversation
Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
|
👋 Hi ovidiusm! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
yosefe
previously approved these changes
Jul 25, 2025
Contributor
|
/build |
yosefe
enabled auto-merge (squash)
July 25, 2025 11:09
aranadive
reviewed
Jul 25, 2025
Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
Contributor
Author
|
/build |
brminich
reviewed
Jul 31, 2025
Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
yosefe
reviewed
Aug 3, 2025
Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
ovidiusm
disabled auto-merge
August 5, 2025 08:47
Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
…lt in debug mode Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
Contributor
Author
|
/build |
brminich
reviewed
Aug 11, 2025
Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
Contributor
Author
|
/build |
Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
Contributor
Author
|
/build |
brminich
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add option for build mode in the container, build nixl and nixlbench in release mode by default
Why?
Up to 1-10% better performance in DRAM tests (more for smaller buffers)