-
Notifications
You must be signed in to change notification settings - Fork 179
clang-tidy: Add config to enforce naming style #575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi w1ldptr! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
Signed-off-by: Vlad Buslov <[email protected]>
rakhmets
reviewed
Jul 15, 2025
Co-authored-by: Raul Akhmetshin <[email protected]> Signed-off-by: Vlad Buslov <[email protected]>
Signed-off-by: Vlad Buslov <[email protected]>
|
/build |
|
/build |
|
/ok to test d8254e0 |
barneuman
approved these changes
Jul 17, 2025
yosefe
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Create a config file for clang-tidy tool in order to enforce naming style of types, functions, and variables according to NIXL code style.
Why?
Both internal and external contributors have often been naming types, functions, and variables incorrectly. Moreover, due to complex NIXL naming conventions these mistakes often slip past code review.
How?
Clang-tidy is a tool readily available in Ubuntu and other distro's repositories similarly to clang-format that is already used by NIXL. Excerpt from the tool output with provided config on a NIXL source: