NIXLBench: Align memory for O_DIRECT - #557
Merged
aranadive merged 25 commits intoJul 16, 2025
Merged
Conversation
|
👋 Hi cheese-head! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
Contributor
Author
|
cherry pick of 504 |
Signed-off-by: Patrick Riel <priel@nvidia.com>
cheese-head
requested review from
aranadive,
brminich and
ovidiusm
as code owners
July 10, 2025 14:17
Signed-off-by: Patrick Riel <priel@nvidia.com>
vvenkates27
previously approved these changes
Jul 10, 2025
vvenkates27
left a comment
vvenkates27
left a comment
Contributor
There was a problem hiding this comment.
mostly just sytle changes and includes posix_memalign. LGTM
ovidiusm
reviewed
Jul 10, 2025
ovidiusm
previously approved these changes
Jul 10, 2025
aranadive
reviewed
Jul 14, 2025
aranadive
reviewed
Jul 14, 2025
vvenkates27
reviewed
Jul 15, 2025
aranadive
reviewed
Jul 15, 2025
aranadive
reviewed
Jul 15, 2025
Signed-off-by: Patrick Riel <priel@nvidia.com>
aranadive
approved these changes
Jul 15, 2025
Contributor
|
/ok to test 4105513 |
Contributor
|
/build |
vvenkates27
self-requested a review
July 15, 2025 19:17
vvenkates27
approved these changes
Jul 15, 2025
Contributor
|
/ok to test 4044503 |
Contributor
|
/build |
aranadive
added a commit
to aranadive/nixl
that referenced
this pull request
Jul 16, 2025
* update nixlbench/kvbench docs * updated readme * update readme * update tutorial for gds * apply lint rules * isort fix * enable direct io support in nixlbench * apply clang-format Signed-off-by: Patrick Riel <priel@nvidia.com> * fix clang-formatting Signed-off-by: Patrick Riel <priel@nvidia.com> * check for null pointer Signed-off-by: Patrick Riel <priel@nvidia.com> * merge main * revert clang formatting * calculate page size during init * refactor transfer mem allocation * add optional param for calloc allocations Signed-off-by: Patrick Riel <priel@nvidia.com> --------- Signed-off-by: Patrick Riel <priel@nvidia.com> Co-authored-by: Adit Ranadive <aranadive@nvidia.com>
pvijayakrish
pushed a commit
that referenced
this pull request
Jul 17, 2025
* update nixlbench/kvbench docs * updated readme * update readme * update tutorial for gds * apply lint rules * isort fix * enable direct io support in nixlbench * apply clang-format * fix clang-formatting * check for null pointer * merge main * revert clang formatting * calculate page size during init * refactor transfer mem allocation * add optional param for calloc allocations --------- Signed-off-by: Patrick Riel <priel@nvidia.com> Co-authored-by: Patrick <71560045+cheese-head@users.noreply.github.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR provides support for O_DIRECT in NIXLBench.
Why?
To provide a more accurate representation of storage access performance when using the POSIX Plugin
How?
It aligns memory to the underlying page size using posix_memalign