Upgrade ssl dependency for wheel - #488
Merged
Merged
Conversation
Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
|
👋 Hi ovidiusm! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
yosefe
previously approved these changes
Jun 19, 2025
Contributor
|
/build |
aranadive
reviewed
Jun 19, 2025
aranadive
previously approved these changes
Jun 19, 2025
Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
Contributor
|
/build |
aranadive
approved these changes
Jun 19, 2025
aranadive
left a comment
aranadive
left a comment
Contributor
There was a problem hiding this comment.
I tested with building the manylinux docker image. Then deploying the wheel on an ubuntu24.04. Checked that the libssl, libcrypto dependencies for etcd were linked to host ones. Then ran partial_md_example.py with the NIXL_ETCD_ENDPOINTS set to use ETCD which passed.
aranadive
pushed a commit
to aranadive/nixl
that referenced
this pull request
Jun 19, 2025
* Add openssl3 and grpc from source. This avoids using the libssl1 libraries. Signed-off-by: Ovidiu Mara <ovidium@nvidia.com> * Remove completely libssl and libcrypto from packaged wheel Signed-off-by: Ovidiu Mara <ovidium@nvidia.com> --------- Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
nv-anants
pushed a commit
that referenced
this pull request
Jun 20, 2025
* Add openssl3 and grpc from source. This avoids using the libssl1 libraries. * Remove completely libssl and libcrypto from packaged wheel --------- Signed-off-by: Ovidiu Mara <ovidium@nvidia.com> Signed-off-by: Adit Ranadive <aranadive@nvidia.com> Co-authored-by: ovidiusm <ovidium@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Use newer SSL for building the wheel, but remove the binaries from packaging
Why?
The base image has a very old version