nixl/plug_mr: Fix unload of static plugins - #43
Merged
Merged
Conversation
mkhazraee
reviewed
Mar 17, 2025
mkhazraee
approved these changes
Mar 17, 2025
aranadive
force-pushed
the
aranadive/fix_splugins
branch
from
March 17, 2025 04:29
7b5ae1b to
7d778e1
Compare
aranadive
force-pushed
the
aranadive/fix_splugins
branch
from
March 17, 2025 04:43
7d778e1 to
730dcb7
Compare
aranadive
force-pushed
the
aranadive/fix_splugins
branch
from
March 17, 2025 04:53
730dcb7 to
b8c5e8c
Compare
Static plugins are always loaded so any unload of them should be prevented. I modified the test to make sure that if there is a static plugin it persists through load nad unload of plugins. Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
aranadive
force-pushed
the
aranadive/fix_splugins
branch
from
March 17, 2025 05:12
b8c5e8c to
746f8d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static plugins are always loaded so any unload of them should be prevented. I modified the test to make sure that if there is a static plugin it persists through load nad unload of plugins.